Improve error checking in rt.sh #2388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In /github/workspace/tests/rt_utils.sh line 130:
local test_status='PASS'
^---------^ SC2034 (warning): test_status appears unused. Verify use (or export if used externally).
BrianCurtis-NOAA
previously approved these changes
Aug 5, 2024
|
Regression test passed on Hera. RegressionTests_hera.log |
|
I tested this on WCOSS2 with #2183 and the full suite passed. Since there were no errors, I can't verify how it performs if there was one. At least, though, it doesn't cause issue with a no-error RT suite. |
14 tasks
NickSzapiro-NOAA
added a commit
to NickSzapiro-NOAA/ufs-weather-model
that referenced
this pull request
Aug 21, 2024
Improve error checking in rt.sh ufs-community#2388
|
merged with #2389 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Queue Requirements:
Description:
Update rt scripts to fix checking the job exit status from Slurm and PBS schedulers. Fix checking the return code from check_results function, code from check_results is now inlined in run_test.sh. Add new test in error-test.conf to check for job wall clock timeout error. See #2379 for details.
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: